Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #21, Add idle task while loop back in #25

Merged
merged 1 commit into from
May 31, 2022
Merged

Fix #21, Add idle task while loop back in #25

merged 1 commit into from
May 31, 2022

Conversation

skliper
Copy link
Contributor

@skliper skliper commented May 25, 2022

Checklist (Please check before submitting)

Describe the contribution

Testing performed
CI

Expected behavior changes
Idle task loops and should report hogging correctly (should check with functional test)

System(s) tested on

  • Hardware: i5/wsl
  • OS: Ubuntu 18.04
  • Versions: Bundle main + this commit

Additional context
Still need to finish testing

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added this to the Draco milestone May 25, 2022
@astrogeco
Copy link
Contributor

astrogeco commented May 25, 2022 •
edited
Loading

CCB:2022-05-25 APPROVED

  • haven't done extensive testing yet
  • coverage went down since we added new functions
  • CTF test is hanging on SP0

@skliper
Copy link
Contributor Author

skliper commented May 25, 2022

Confirmed hogging is no longer reported on startup from the CI log: https://github.com/nasa/HS/actions/runs/2385717353. Note the added lines adds to uncovered line count so coverage fails, but this should get fixed with the rest of the coverage updates.

@skliper skliper marked this pull request as ready for review May 25, 2022 16:50
@astrogeco astrogeco merged commit 85e942d into nasa:main May 31, 2022
@skliper skliper deleted the fix21-idle_task_loop branch May 31, 2022 16:30
@skliper skliper mentioned this pull request May 31, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CCB:Approved draco-rc2
Projects
None yet
Milestone
Draco
Development

Successfully merging this pull request may close these issues.

HS idle task only executes once and exits... reports CPU hogging all the time
2 participants
@skliper @astrogeco